Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v2.8] OOB Charts release for rancher-webhook 2.0.6+up0.3.6, elemental 103.0.0+up1.3.4, rancher-vsphere-cpi 103.0.0+up1.6.0 and rancher-vsphere-csi 103.0.0+up3.0.2-rancher1 #3187

Merged
merged 7 commits into from
Oct 24, 2023
Merged

[release-v2.8] OOB Charts release for rancher-webhook 2.0.6+up0.3.6, elemental 103.0.0+up1.3.4, rancher-vsphere-cpi 103.0.0+up1.6.0 and rancher-vsphere-csi 103.0.0+up3.0.2-rancher1 #3187

merged 7 commits into from
Oct 24, 2023

Conversation

lucasmlp
Copy link
Contributor

@lucasmlp lucasmlp commented Oct 24, 2023 •
edited
Loading

Issues:

rancher-webhook:

elemental:

rancher-vsphere-cpi and rancher-vsphere-csi:

Charts Checklist (built for v0.5.2 charts-build-scripts)

Checkpoint 0: Validate release.yaml

Validation steps:

  • Each chart version in release.yaml DOES NOT modify an already released chart. If so, stop and modify the versions so that it releases a net-new chart.
  • Each chart version in release.yaml IS exactly 1 more patch version than the last released chart version. If not, stop and modify the versions so that it releases a net-new chart.

Checkpoint 1: Compare contents of assets/ to charts/

Validation steps:

  • Running make unzip to regenerate the charts/ from scratch, then git diff to check differences between assets/ and charts/ yields NO differences or innocuous differences.

IMPORTANT: Do not undo these changes for future steps since we want to keep the charts/ that match the current contents of assets!

Checkpoint 2: Compare assets against index.yaml

Validation steps:

  • The index.yaml file has an entry for each chart version. (Automated by make validate)
  • The index.yaml entries for each chart matches the Chart.yaml for each chart. (Automated by make validate)
  • Each chart has ALL required annotations
    • kube-version annotation
    • rancher-version annotation
    • permits-os annotation (indicates Windows and/or Linux)

@github-actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:- 
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@fgiudici @lucasmlp
Add Elemental packages
1e85ca8 
Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
@fgiudici @lucasmlp
make charts
7d4e5c9 
Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
@fgiudici @lucasmlp
update release.yaml
ca60c3d 
Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
@github-actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:- 
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@lucasmlp lucasmlp changed the title [release-v2.8] OOB Charts release for rancher-webhook 2.0.6+up0.3.6 [release-v2.8] OOB Charts release for rancher-webhook 2.0.6+up0.3.6, elemental 103.0.0+up1.3.4 and rancher-vsphere-cpi 103.0.0+up1.6.0 Oct 24, 2023
@lucasmlp lucasmlp changed the title [release-v2.8] OOB Charts release for rancher-webhook 2.0.6+up0.3.6, elemental 103.0.0+up1.3.4 and rancher-vsphere-cpi 103.0.0+up1.6.0 [release-v2.8] OOB Charts release for rancher-webhook 2.0.6+up0.3.6, elemental 103.0.0+up1.3.4, rancher-vsphere-cpi 103.0.0+up1.6.0 and 103.0.0+up3.0.2-rancher1-vsphere-csi Oct 24, 2023
@lucasmlp lucasmlp changed the title [release-v2.8] OOB Charts release for rancher-webhook 2.0.6+up0.3.6, elemental 103.0.0+up1.3.4, rancher-vsphere-cpi 103.0.0+up1.6.0 and 103.0.0+up3.0.2-rancher1-vsphere-csi [release-v2.8] OOB Charts release for rancher-webhook 2.0.6+up0.3.6, elemental 103.0.0+up1.3.4, rancher-vsphere-cpi 103.0.0+up1.6.0 and rancher-vsphere-csi 103.0.0+up3.0.2-rancher1 Oct 24, 2023
@github-actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:- 
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@github-actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:- 
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@rohitsakala rohitsakala added the regsync-ready PR ready to sync images with prime registry label Oct 24, 2023
@github-actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:- 
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@rohitsakala rohitsakala merged commit bda55d3 into release-v2.8 Oct 24, 2023
5 checks passed
@rohitsakala rohitsakala deleted the oob-2-8-part-2 branch October 24, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitsakala rohitsakala rohitsakala approved these changes

Assignees
No one assigned
Labels
regsync-ready PR ready to sync images with prime registry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lucasmlp @rohitsakala @fgiudici @nicholasSUSE @a-blender @rancherbot